Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Add support for the jsoncs3 public share manager #4548

Merged
merged 7 commits into from
Sep 9, 2022
Merged

[full-ci] Add support for the jsoncs3 public share manager #4548

merged 7 commits into from
Sep 9, 2022

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Sep 9, 2022 •
edited by micbar
Loading

This PR allows for configuring the jsoncs3 public share manager from cs3org/reva#3199

FIxes #3881
Fixes #2164

@update-docs
Copy link

update-docs bot commented Sep 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

butonic
butonic approved these changes Sep 9, 2022
View reviewed changes
services/sharing/pkg/config/config.go Outdated Show resolved Hide resolved
ocis/pkg/command/migrate.go Outdated Show resolved Hide resolved
services/sharing/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
@butonic
Copy link
Member

butonic commented Sep 9, 2022

and add a go.mod update?

@butonic
make jsoncs3 default public share backend
40b7aaa 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@ownclouders
Copy link
Contributor

ownclouders commented Sep 9, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-5 failed. Further test are cancelled...

@micbar
Copy link
Contributor

micbar commented Sep 9, 2022 •
edited
Loading

fails with

{"level":"error","service":"sharing","error":"unable to register services: rgrpc: grpc service publicshareprovider could not be started,: error: not found: driver not found: jsoncs3","time":"2022-09-09T11:59:53.011937951Z","message":"error starting the grpc server"}

aduffeck and others added 5 commits September 9, 2022 15:25
@aduffeck @butonic
Update services/sharing/pkg/config/config.go
a107924 
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@aduffeck @butonic
Update ocis/pkg/command/migrate.go
8bdfe5f 
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@aduffeck @butonic
Update services/sharing/pkg/revaconfig/config.go
291e191 
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar
Update reva
c6faf4a
@micbar
Update expected failures
48e6400
@micbar micbar changed the title Add support for the jsoncs3 public share manager [full-ci] Add support for the jsoncs3 public share manager Sep 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.7% 2.7% Duplication

@micbar micbar merged commit 1e82d80 into owncloud:master Sep 9, 2022
ownclouders pushed a commit that referenced this pull request Sep 9, 2022
@micbar
commit 1e82d80
a035a82 
Merge: c6b67db 48e6400
Author: Michael Barz <mbarz@owncloud.com>
Date:   Fri Sep 9 21:16:01 2022 +0200

    Merge pull request #4548 from aduffeck/jsoncs3-publicshare-manager

    [full-ci] Add support for the jsoncs3 public share manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@aduffeck @butonic @ownclouders @micbar