Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApiTest. search entity from project space and shares jail #4054

Merged
merged 2 commits into from
Jun 30, 2022
Merged

ApiTest. search entity from project space and shares jail #4054

merged 2 commits into from
Jun 30, 2022

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jun 28, 2022 •
edited
Loading

Changes in 2 PR. related with owncloud/core#40174

@update-docs
Copy link

update-docs bot commented Jun 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor force-pushed the searchInProjectSpace branch from 8edd7e8 to a778229 Compare June 29, 2022 08:23
@ownclouders
Copy link
Contributor

ownclouders commented Jun 29, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

individual-it
individual-it reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't those cases tested already in https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavOperations/search.feature ?

@SagarGi
Copy link
Member

SagarGi commented Jun 30, 2022

aren't those cases tested already in https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavOperations/search.feature ?

@individual-it I think search.feature has only tests for project space not for shares jail in core.

individual-it
individual-it reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before merging owncloud/core#40174 needs to get merged and the .drone.env file reverted

tests/acceptance/features/bootstrap/SpacesContext.php
Comment on lines -385 to +387
public function deleteAllSpacesOfTheType(string $driveType): void
{
public function deleteAllSpacesOfTheType(string $driveType): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we run PHP lint here? this should have been caught by CI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran make test-php-style-fix and got No fixable errors were found

@ScharfViktor
Copy link
Contributor Author

aren't those cases tested already in https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavOperations/search.feature ?

@individual-it I think search.feature has only tests for project space not for shares jail in core.

in core repository we have only tests for searching in personal space. so additionally I made a change in core

@ScharfViktor
add search test
01677b3 
add new line to the end

change coreCommitId

change coreCommitId

revert CORE_BRANCH
@ScharfViktor ScharfViktor force-pushed the searchInProjectSpace branch from cbb2096 to 01677b3 Compare June 30, 2022 08:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor requested a review from phil-davis June 30, 2022 09:06
@phil-davis phil-davis mentioned this pull request Jun 30, 2022
Closed
9 tasks
@phil-davis phil-davis merged commit 4e07dae into master Jun 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the searchInProjectSpace branch June 30, 2022 09:42
@phil-davis phil-davis mentioned this pull request Jun 30, 2022
Closed
15 tasks
ownclouders pushed a commit that referenced this pull request Jun 30, 2022
@phil-davis
commit 4e07dae
3690aa6 
Merge: 86f7366 6b5748e
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Jun 30 15:27:37 2022 +0545

    Merge pull request #4054 from owncloud/searchInProjectSpace

    ApiTest. search entity from project space and shares jail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it left review comments

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScharfViktor @ownclouders @SagarGi @phil-davis @individual-it