Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share events for audit logging #3301

Merged
merged 10 commits into from
Mar 14, 2022
Merged

Share events for audit logging #3301

merged 10 commits into from
Mar 14, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Mar 11, 2022 •
edited
Loading

Description

Adds sharing events to the audit logging service

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • unit tests run in ci-pipeline

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

kobergj added 9 commits March 11, 2022 12:14
@kobergj
share updated event
c7952c2 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
link created/updated event
7f0fff0 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
add changelog
5f45e77 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
share/link removed events
0de5dac 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
refactor unit tests
ef642ac 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
more unit tests and events
2fa0849 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
share accepted/declined events
f012638 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
link access events
22bb75a 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj
bump reva & run unit tests
50d3ef4 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj force-pushed the ShareEventsForAuditLogging branch from 68d2fe5 to 50d3ef4 Compare March 14, 2022 09:44
@kobergj
use UTC timezone to avoid confusion
5ea1cec 
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

9.7% 9.7% Coverage
0.0% 0.0% Duplication

@kobergj kobergj marked this pull request as ready for review March 14, 2022 10:26
@kobergj kobergj requested review from butonic, rhafer and C0rby and removed request for phil-davis and individual-it March 14, 2022 10:27
@wkloucek wkloucek merged commit 417b112 into owncloud:master Mar 14, 2022
@kobergj kobergj deleted the ShareEventsForAuditLogging branch March 14, 2022 14:05
@micbar micbar mentioned this pull request Mar 29, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@micbar micbar Awaiting requested review from micbar

@butonic butonic Awaiting requested review from butonic

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @C0rby @wkloucek