Simplify config #329
Merged
Simplify config #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have this in my oCIS config file: which works... |
|
Accounts service doesn't have a tracing config so far. |
butonic
approved these changes
Jun 30, 2020
|
@refs would be nice to get your opinion on this... also: needs a rebase |
|
rebased + added jaeger endpoint and collector as default values |
|
but proxy is still not sending spans, tracked in https://github.com/owncloud/ocis-proxy/issues/61 |
refs
approved these changes
Jul 1, 2020
| cfg.Proxy.Tracing.Service = cfg.Tracing.Service | ||
| } | ||
|
|
||
| if cfg.Reva.Reva.JWTSecret != "" { |
There was a problem hiding this comment.
We might want to look at this struct. cfg.Reva.Reva seems redundant. Issue for another time :)
kulmann
force-pushed
the
simplify-config
branch
from
4d9212e to
ded9a01
Compare
|
rebased to current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the
OCIS_TRACING_*config variables become the global config for all services. If you want to set individual tracing config for each service, setOCIS_TRACING_ENABLED=false(which is the default) and configure tracing for all services individually.Tracing documentation updated as well, to reflect both different usages (global config and per-service config).
Implementation for owncloud/product#92