Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] bumped core commit Id on ocis to include this PR 39828 #3246

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

sushmita56
Copy link
Contributor

Description

Bump core commit id on ocis to include this PR owncloud/core#39828

Related Issue

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled...

@phil-davis
Copy link
Contributor

The whole file has been re-formatted so that each entry has a dash "-" followed by just a single space, then the reference to the failing test scenario. Previously, for reasons that I do not know, there were 3 spaces.

Actually it is probably good to have just 1 space, so we may as well do that now! But we should also make sure to do it for all other expected-failures files as we touch thme.

@kiranparajuli589 @Talank @SwikritiT @saw-jan @individual-it any opinions?

@kiranparajuli589
Copy link
Contributor

The whole file has been re-formatted so that each entry has a dash "-" followed by just a single space, then the reference to the failing test scenario. Previously, for reasons that I do not know, there were 3 spaces.

Actually it is probably good to have just 1 space, so we may as well do that now! But we should also make sure to do it for all other expected-failures files as we touch thme.

@kiranparajuli589 @Talank @SwikritiT @saw-jan @individual-it any opinions?

I support the single space solution everywhere.

@saw-jan
Copy link
Member

saw-jan commented Mar 1, 2022

Previously, we had a discussion about 3 spaces but I also couldn't recall why we used 3 spaces.
prettier in Vscode formats the .md file this way. I don't know about IntelliJ whether it will reformat again or not.
But these changes would be good to have if no problems will arise.

@phil-davis phil-davis force-pushed the bump-core-commitId-ocis branch from d1d2e6e to abe1d6b Compare March 1, 2022 09:19
@phil-davis
Copy link
Contributor

I pushed a commit to remove the excess white-space from the other expected-failures files.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sushmita56 sushmita56 marked this pull request as ready for review March 1, 2022 09:40
@phil-davis phil-davis merged commit 27c4b7b into master Mar 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-core-commitId-ocis branch March 1, 2022 10:04
ownclouders pushed a commit that referenced this pull request Mar 1, 2022
Merge: ccf6bf1 abe1d6b
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Mar 1 15:49:00 2022 +0545

    Merge pull request #3246 from owncloud/bump-core-commitId-ocis

    [tests-only] bumped core commit Id on ocis to include this PR 39828
ownclouders pushed a commit that referenced this pull request Mar 2, 2022
Merge: ccf6bf1 abe1d6b
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Mar 1 15:49:00 2022 +0545

    Merge pull request #3246 from owncloud/bump-core-commitId-ocis

    [tests-only] bumped core commit Id on ocis to include this PR 39828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants