-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces filters #2946
Spaces filters #2946
Conversation
18be145
to
a544602
Compare
💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled... |
a544602
to
3fbc255
Compare
@kobergj let me add some API tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not so nitpicky nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice from my POV
f054185
to
63550eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test could be less redundant.
Co-authored-by: Jörn Friedrich Dreyer <jfd@owncloud.com>
53d2c1a
to
16c7706
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
This adds two possible filter terms (driveType, id) to the /me/drives endpoint on the graph api. These can be used with the odata query parameter "$filter".
We only support the "eq" operator for now.
This is leveraging the
spaces-registry
branch and needs to be rebased after that one has been merged.Examples
Filter by Id
Filter by type
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: