Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph api rest #2869

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Graph api rest #2869

merged 5 commits into from
Dec 13, 2021

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Dec 11, 2021

Description

  • Handle empty spaces during update
  • Change the update space api scheme to PATCH /drives/{drive-id}

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar changed the base branch from master to graph-update December 11, 2021 20:55
@micbar micbar changed the base branch from graph-update to master December 11, 2021 20:55
@micbar micbar self-assigned this Dec 11, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@micbar micbar requested a review from refs December 12, 2021 19:39
@micbar micbar requested a review from butonic December 13, 2021 08:18
go.mod Outdated Show resolved Hide resolved
graph/pkg/service/v0/drives.go Outdated Show resolved Hide resolved
@micbar micbar requested a review from kobergj December 13, 2021 15:22
@micbar micbar requested a review from C0rby December 13, 2021 15:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 04145b2 into master Dec 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the graph-api-rest branch December 13, 2021 18:59
ownclouders pushed a commit that referenced this pull request Dec 13, 2021
Merge: 10ef31c 23458ba
Author: Michael Barz <mbarz@owncloud.com>
Date:   Mon Dec 13 19:59:01 2021 +0100

    Merge pull request #2869 from owncloud/graph-api-rest

    Graph api rest
@butonic
Copy link
Member

butonic commented Dec 15, 2021

@micbar why did you rip out godata?

@refs
Copy link
Member

refs commented Dec 15, 2021

@micbar why did you rip out godata?

IIRC we're not using odata in favor of "traditional" REST. I initially implemented the drives endpoint using OData queries but I think it was too confusing (?) and it was moved to the usual verbs... which I don't like, I'd rather stick to the usual OData on msgraph, since we can leverage the power of OData 🤷‍♀️

There is more info in the PR that gets rids of odata on our graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants