Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Bugfix: Disallow creation of a group with empty name via the OCS api #2825

Merged
merged 5 commits into from
Nov 28, 2021
Merged

[full-ci] Bugfix: Disallow creation of a group with empty name via the OCS api #2825

merged 5 commits into from
Nov 28, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 26, 2021 •
edited
Loading

Description

We've fixed the behavior for group creation on the OCS api, where it was
possible to create a group with an empty name. This was is not possible
on oC10 and is therefore also forbidden on oCIS to keep compatibility.
This PR forbids the creation and also ensures the correct status codef
or both OCS v1 and OCS v2 apis.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek changed the title Bugfix: Disallow creation of a group with empty name via the OCS api [full ci] Bugfix: Disallow creation of a group with empty name via the OCS api Nov 26, 2021
@wkloucek wkloucek force-pushed the fix-create-group-no-name branch from 3799945 to 9a123d5 Compare November 26, 2021 11:29
@phil-davis
Copy link
Contributor

phil-davis commented Nov 26, 2021 •
edited
Loading

@wkloucek I just merged #2801 - that includes the tests for this from core.
Please rebase this PR. Then you should get 2 unexpected test scenarios passing, and you can remove them from expected-failures.

@wkloucek wkloucek force-pushed the fix-create-group-no-name branch from 9a123d5 to dc5901b Compare November 26, 2021 12:04
@wkloucek @phil-davis
Update changelog/unreleased/fix-create-group-without-name.md
e6ca10c 
Co-authored-by: Phil Davis <phil@jankaritech.com>
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled...

@wkloucek wkloucek changed the title [full ci] Bugfix: Disallow creation of a group with empty name via the OCS api [full-ci] Bugfix: Disallow creation of a group with empty name via the OCS api Nov 26, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
33.5% 33.5% Duplication

@phil-davis phil-davis merged commit c907e24 into master Nov 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-create-group-no-name branch November 28, 2021 11:19
@wkloucek wkloucek mentioned this pull request Nov 29, 2021
Merged
@saw-jan saw-jan mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@refs refs refs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a group with empty name returns success status
4 participants
@wkloucek @phil-davis @ownclouders @refs