Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idp: Create parent directories if they don't exist #2667

Merged
merged 1 commit into from
Oct 22, 2021
Merged

idp: Create parent directories if they don't exist #2667

merged 1 commit into from
Oct 22, 2021

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Oct 22, 2021

Description

The parent directories of the identifier-registration.yaml config file might
not exist when starting idp. So instead of creating just the top most
directory use MkdirAll to also create the parents.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@rhafer rhafer added the Status:Needs-Review Needs review from a maintainer label Oct 22, 2021
@rhafer rhafer self-assigned this Oct 22, 2021
@rhafer
idp: Create parent directories if they don't exist
9e8231a 
The parent directories of the identifier-registration.yaml config file might
not exist when starting idp. So instead of creating just the top most
directory use MkdirAll to also create the parents.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

13.7% 13.7% Coverage
13.4% 13.4% Duplication

C0rby
C0rby approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was annoying me too. Thanks! 👍

@C0rby C0rby merged commit e146b03 into owncloud:master Oct 22, 2021
ownclouders pushed a commit that referenced this pull request Oct 22, 2021
commit e146b03
b51ffae 
Merge: 087a142 9e8231a
Author: David Christofas <dchristofas@owncloud.com>
Date:   Fri Oct 22 17:41:12 2021 +0200

    Merge pull request #2667 from rhafer/mkdir-idp

    idp: Create parent directories if they don't exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

Assignees

@rhafer rhafer

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhafer @C0rby