enforce set space quota permission #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
C0rby
force-pushed
the
graph-update-drive
branch
from
0b85e1e to
99fb935
Compare
micbar
approved these changes
Oct 22, 2021
💥 Acceptance tests localApiTests-apiSpaces-ocis failed. The build is cancelled... |
|
@C0rby Before your PR, the list spaces response was returning the Displayname of the User for the personal space. Now it is returning "root" |
|
this is the problem https://github.com/cs3org/reva/pull/2162/files#diff-d308a0558595437a537e77e29346472e66ab3bc31c213fcd2dd9b5f64c02aa91R348-R357 You brought back old behavior that was already changed |
|
Ah then I must have lost that while rebasing... |
|
I'll open another PR in reva... |
💥 Acceptance tests localApiTests-apiSpaces-ocis failed. The build is cancelled... |
refs
approved these changes
Oct 22, 2021
C0rby
force-pushed
the
graph-update-drive
branch
2 times, most recently
from
4315ded to
1d48fef
Compare
C0rby
force-pushed
the
graph-update-drive
branch
from
1d48fef to
c23071f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enforces the set-space-quota permission on the update storage space /update drive request.
Before merging this we need: cs3org/reva#2162 in reva first.
Types of changes
Checklist: