Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix identifier-registration.yaml creation #2648

Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix identifier-registration.yaml creation #2648

merged 1 commit into from
Oct 20, 2021

Conversation

wkloucek
Copy link
Contributor

Description

#2590 changed the path for the identifier-registration.yaml but the creation of the file failed because it used hardcoded paths. This PR makes the file creation logic using the provided path.

(No changelog needed since the bug was introduced in #2590, which wasn't part of a release yet)

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested review from jvillafanez and refs October 20, 2021 09:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 77b7694 into master Oct 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_identifier_registration_yaml_creation branch October 20, 2021 10:41
ownclouders pushed a commit that referenced this pull request Oct 20, 2021
@wkloucek
commit 77b7694
29b1bb6 
Merge: 24b851a 562c376
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Wed Oct 20 12:41:36 2021 +0200

    Merge pull request #2648 from owncloud/fix_identifier_registration_yaml_creation

    fix identifier-registration.yaml creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @jvillafanez