Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the account resolver middleware #2557

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix the account resolver middleware #2557

merged 1 commit into from
Sep 29, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Sep 29, 2021

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

https://github.com/owncloud/ocis/pull/2528/files#diff-623d75273ecaa16479d6e4250fc36a6a015841b8e569bd5c2dedd7af30c0c19cL111-L122 This part was removed and hasn't been replaced. This caused the token to be empty in certain cases.

How Has This Been Tested?

  • manually, locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@C0rby C0rby added the Status:Needs-Review Needs review from a maintainer label Sep 29, 2021
@C0rby C0rby requested review from butonic, refs and wkloucek September 29, 2021 08:22
@C0rby C0rby self-assigned this Sep 29, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

29.4% 29.4% Coverage
0.0% 0.0% Duplication

@C0rby C0rby merged commit a35c406 into master Sep 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-account_resolver branch September 29, 2021 08:54
ownclouders pushed a commit that referenced this pull request Sep 29, 2021
commit a35c406
b8c8869 
Merge: 86728bc 04a8ef7
Author: David Christofas <dchristofas@owncloud.com>
Date:   Wed Sep 29 10:54:11 2021 +0200

    Merge pull request #2557 from owncloud/fix-account_resolver

    fix the account resolver middleware
@refs refs mentioned this pull request Sep 29, 2021
Merged
9 tasks
@pascalwengerter pascalwengerter mentioned this pull request Sep 29, 2021
Closed
@fschade fschade mentioned this pull request Oct 18, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@butonic butonic Awaiting requested review from butonic

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees

@C0rby C0rby

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @refs