Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the REPORT API with the filter-files filter #2520

Merged
merged 1 commit into from
Oct 5, 2021
Merged

add the REPORT API with the filter-files filter #2520

merged 1 commit into from
Oct 5, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Sep 17, 2021

Description

Updated reva to pull in the enhanced REPORT API. Also updated the frontend command to include the new config options for the favorites manager.

Related Issue

Motivation and Context

cs3org/reva#2036

How Has This Been Tested?

  • reva ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 17, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@C0rby C0rby force-pushed the add-list-favorite-api branch from c69f8bb to ac2639b Compare September 17, 2021 10:28
@ownclouders
Copy link
Contributor

💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled...

1 similar comment
@ownclouders
Copy link
Contributor

💥 Acceptance tests localApiTests-apiAccountsHashDifficulty-ocis failed. The build is cancelled...

@C0rby C0rby force-pushed the add-list-favorite-api branch from ac2639b to b396e79 Compare September 17, 2021 12:16
@ownclouders
Copy link
Contributor

💥 Acceptance tests Core-API-Tests-ocis-storage-1 failed. The build is cancelled...

@C0rby C0rby force-pushed the add-list-favorite-api branch 2 times, most recently from e81c194 to 9a69994 Compare September 17, 2021 14:43
@C0rby C0rby marked this pull request as ready for review September 17, 2021 14:44
@C0rby C0rby requested review from refs, wkloucek and butonic and removed request for wkloucek September 17, 2021 14:44
@C0rby C0rby self-assigned this Sep 17, 2021
@C0rby C0rby marked this pull request as draft September 17, 2021 15:12
@C0rby
Copy link
Contributor Author

C0rby commented Sep 24, 2021

This PR is still in the draft state because the required PR in reva got reverted. Once the new PR cs3org/reva#2086 in reva is merged we can merge this here too.

@C0rby C0rby force-pushed the add-list-favorite-api branch from 9a69994 to 3fb8845 Compare October 5, 2021 13:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@C0rby C0rby marked this pull request as ready for review October 5, 2021 13:41
@C0rby C0rby merged commit 0b789e5 into master Oct 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-list-favorite-api branch October 5, 2021 13:59
ownclouders pushed a commit that referenced this pull request Oct 5, 2021
commit 0b789e5
bef024a 
Merge: 7be75f5 3fb8845
Author: David Christofas <dchristofas@owncloud.com>
Date:   Tue Oct 5 15:59:13 2021 +0200

    Merge pull request #2520 from owncloud/add-list-favorite-api

    add the REPORT API with the filter-files filter
@wkloucek wkloucek mentioned this pull request Oct 6, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@refs refs Awaiting requested review from refs

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C0rby @ownclouders @butonic