-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redirect to root when file not found #2493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
force-pushed
the
web_not_found_redirect
branch
from
September 13, 2021 17:33
4162bcd
to
5298b4b
Compare
wkloucek
requested review from
butonic
and removed request for
pascalwengerter
September 13, 2021 17:34
Kudos, SonarCloud Quality Gate passed! |
butonic
approved these changes
Sep 15, 2021
ownclouders
pushed a commit
that referenced
this pull request
Sep 15, 2021
9 tasks
wkloucek
added a commit
that referenced
this pull request
Sep 16, 2021
fix: redirect invalid links to oC Web (#2493)
ownclouders
pushed a commit
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Web owns the "/" route in oCIS proxy which will match everything not matching any other more specific route. All these requests will end in the static file serve block which just returns a 404 not found. Ideally we would display a dedicated not found page which is should be included in the static files. Until we have a site like this we can redirect requests to the root, from which oC Web is served. This helps people having non valid links (eg. oC 10 links like https://foo.bar/index.php/apps/pdfviewer...) to not beeing stuck to a blank page saying "not found".
Related Issue
Motivation and Context
Bookmarked links from eg. ownCloud 10 which are no longer supported after an migration will lead to ownCloud web instead displaying a blank page (with the text "not found").
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: