Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from kc/konnect to libregraph/lico #2371

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Aug 9, 2021

This switches the oidc implementation to libregraph/lico, which for now
is just a rename of kc/konnect. As there is no working lico release yet
(lico 0.34.0 wasn't fully renamed), we point it to the current master.

@rhafer rhafer requested a review from butonic August 9, 2021 13:44
@rhafer rhafer self-assigned this Aug 9, 2021
@update-docs
Copy link

update-docs bot commented Aug 9, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic
Copy link
Member

butonic commented Aug 10, 2021

could you search for konnect and replace occurrences with meaningful wording where possible, eg. the docs / markdown files, but I also see Dockerfiles and Makefile hits...

This switches the oidc implementation to libregraph/lico, which for now
is just a rename of kc/konnect. As there is no working lico release yet
(lico 0.34.0 wasn't fully renamed), we point it to the current master.
@rhafer rhafer force-pushed the kconnnect-to-lico branch from 5c4f478 to 6dd5be2 Compare August 10, 2021 14:26
@rhafer
Copy link
Contributor Author

rhafer commented Aug 10, 2021

could you search for konnect and replace occurrences with meaningful wording where possible, eg. the docs / markdown files, but I also see Dockerfiles and Makefile hits...

Done

@@ -7,7 +7,7 @@ RUN apk update && \
echo 'hosts: files dns' >| /etc/nsswitch.conf

LABEL maintainer="ownCloud GmbH <devops@owncloud.com>" \
org.label-schema.name="oCIS Konnectd" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic Any idea if these labels are referenced anywhere? Is it safe to just rename them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah can just be renamed :-)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rhafer rhafer requested a review from butonic August 11, 2021 09:32
@butonic butonic merged commit 648cfd0 into owncloud:master Aug 11, 2021
ownclouders pushed a commit that referenced this pull request Aug 11, 2021
Merge: 4119673 6dd5be2
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Wed Aug 11 13:16:03 2021 +0200

    Merge pull request #2371 from rhafer/kconnnect-to-lico

    Move from kc/konnect to libregraph/lico
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants