deployment examples: switch to http internally #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
wkloucek
changed the title
refs
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the deployment examples we switched to HTTPS internally in 3eb9e12#diff-82183c58020714d66867eb24da3765200d315ec2508b7816916567ce534142c7 because there was some configuration dependency whether oCIS runs with https or http and we wanted to stick as close to the default configuration as possible:
The need to set THUMBNAILS_WEBDAVSOURCE_BASEURL was removed in #1898 so we can use http internally again.
Using http between oCIS has the advantage that we don't have to set
insecureSkipVerifyon Traefik.