-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial /me/drives implementation #2007
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
cc @dragotin |
SonarCloud Quality Gate failed. |
blocked by reva PR cs3org/reva#1802 |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
graph/pkg/service/v0/drives.go
Outdated
drive.BaseItem.LastModifiedDateTime = &lastModified | ||
} | ||
if space.Quota != nil { | ||
// FIXME use https://github.com/owncloud/open-graph-api and return proper int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment?
graph/pkg/service/v0/drives.go
Outdated
if res.Type == storageprovider.ResourceType_RESOURCE_TYPE_FILE { | ||
driveItem.File = &msgraph.File{ | ||
driveItem.File = &msgraph.OpenGraphFile{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment why weird type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only cosmetic stuff
Kudos, SonarCloud Quality Gate passed! |
Inital spaces API, following #1827
requires cs3org/reva#1678