remove ocis-hello references #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
force-pushed
the
remove_ocis_hello_references
branch
from
7df2836 to
7a99941
Compare
refs
approved these changes
Apr 19, 2021
wkloucek
force-pushed
the
remove_ocis_hello_references
branch
from
7a99941 to
771f85c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
oCIS shouldn't know anything explicitly about an extension. It should provide interfaces which any extension can use. Therefore ocis-hello shouldn't be treated differently and all references to it will be removed in this PR
Related Issue
Motivation and Context
See what is needed to get an arbitrary extension running with oCIS