Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default path for thumbnails #1892

Merged
merged 1 commit into from
Apr 6, 2021
Merged

change default path for thumbnails #1892

merged 1 commit into from
Apr 6, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 6, 2021 •
edited
Loading

Description

Changes the default path for thumbnails from <os tmp dir>/ocis-thumbnails to /var/tmp/ocis/thumbnails

Related Issue

Motivation and Context

As requested in #1891

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 6, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the change_default_thumbnails_path branch from 925d916 to 80a158b Compare April 6, 2021 09:20
@wkloucek wkloucek marked this pull request as ready for review April 6, 2021 09:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek requested a review from C0rby April 6, 2021 10:00
C0rby
C0rby approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@wkloucek wkloucek merged commit 1fdffed into master Apr 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the change_default_thumbnails_path branch April 6, 2021 11:36
ownclouders pushed a commit that referenced this pull request Apr 6, 2021
@wkloucek
commit 1fdffed
dfb8aa0 
Merge: 076d8c0 80a158b
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Apr 6 13:36:48 2021 +0200

    Merge pull request #1892 from owncloud/change_default_thumbnails_path

    change default path for thumbnails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store thumbnails in a configurable storage location
2 participants
@wkloucek @C0rby