-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reva to latest master #1588
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
5e81b6f
to
1cf4d50
Compare
eee95a8
to
f80b1a8
Compare
I can't reproduce the first trashbin failure but the second is caused by a frontend bug... |
Hm or it is a trashbin api issue because on |
Found the issue:
If you look closely you can see that some characters, which should not get encoded, get encoded... |
Here is the fix for ^ cs3org/reva#1472 |
7e5dd32
to
a1b2d90
Compare
For the last failure we would need to update the webui tests.... |
I bumped the web commit id yesterday in PR #1622 and "it all broke" (tm) https://drone.owncloud.com/owncloud/ocis/3338/41/7 I did not get back to looking at it today. We need to regularly pull the latest web into OCIS, otherwise "stuff happens" and it gets difficult to remember what environment stuff has to be adjusted. |
I found a commit from @IljaN from 7 days ago. I now updated the commit id to that. Let's see if that works. |
cc40f39
to
226f3c0
Compare
466ed0b
to
e329742
Compare
e329742
to
01cccb8
Compare
Co-authored-by: David Christofas <dchristofas@owncloud.com>
01cccb8
to
c426db7
Compare
Kudos, SonarCloud Quality Gate passed! |
Related
owncloud/product#255
owncloud/product#183