Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Adjust the links in the expected-failures file #1485

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

haribhandari07
Copy link
Contributor

Description

"OCIS extension" repos were archived. So, the issues in these archived repos have been moved to ocis. This PR adjust the link to issues in expected-failure file.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what CI says.

Comment on lines 9 to 15
- [apiMain/checksums.feature:24](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiMain/checksums.feature#L24)
- [apiMain/checksums.feature:25](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiMain/checksums.feature#L25)
- [apiMain/checksums.feature:35](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiMain/checksums.feature#L35)
- [apiMain/checksums.feature:36](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiMain/checksums.feature#L36)
- [apiMain/checksums.feature:46](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiMain/checksums.feature#L46)
- [apiMain/checksums.feature:47](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiMain/checksums.feature#L47)
- [apiMain/checksums.feature:50](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiMain/checksums.feature#L50)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised that these need to be added. I don't see where they were also deleted in this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://drone.owncloud.com/owncloud/ocis/2900/24/7

runsh: Total unexpected passed scenarios throughout the test run:
apiMain/checksums.feature:24
apiMain/checksums.feature:25
apiMain/checksums.feature:35
apiMain/checksums.feature:36
apiMain/checksums.feature:46
apiMain/checksums.feature:47
apiMain/checksums.feature:50

@haribhandari07 those should not be added to expected-failures.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 8fe2e72 into master Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-links branch January 26, 2021 08:50
ownclouders pushed a commit that referenced this pull request Jan 26, 2021
Merge: 65bc3f1 bf3fff3
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Jan 26 14:35:47 2021 +0545

    Merge pull request #1485 from owncloud/fix-links

    [Tests-Only] Adjust the links in the expected-failures file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants