Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Pin behat/gherkin because of Gherkin issue 187 #1480

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

phil-davis
Copy link
Contributor

Part of issue owncloud/core#38338

Pin behat/gherkin for now until Gherkin issue Behat/Gherkin#187 has been resolved.

@phil-davis phil-davis self-assigned this Jan 25, 2021
@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 25, 2021

Note: this fixes the local API tests. Needs owncloud/core#38339 merged to get the version pinned for the core API test pipelines.

Edit: done in the 2nd commit

Next we will see if there are adjustments needed to expected-failures because of other core commits of new test code.

Edit: expected-failures have been adjusted. CI should be green now.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 1404a8b into master Jan 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the pin-behat-gherkin branch January 25, 2021 15:03
ownclouders pushed a commit that referenced this pull request Jan 25, 2021
Merge: 1c83fa0 b3636ee
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Jan 25 20:48:45 2021 +0545

    Merge pull request #1480 from owncloud/pin-behat-gherkin

    [tests-only] Pin behat/gherkin because of Gherkin issue 187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants