[tests-only][full-ci] Test for flaky share expiration email #11010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anon-pradip
force-pushed
the
test/test-for-flaky-share-expire-step
branch
2 times, most recently
from
29bd46a to
662b753
Compare
9 tasks
anon-pradip
force-pushed
the
test/test-for-flaky-share-expire-step
branch
3 times, most recently
from
5687f0f to
d46058e
Compare
There was a problem hiding this comment.
after this PR #10920 gets merged, add expiry step and check mail in same scenario
anon-pradip
force-pushed
the
test/test-for-flaky-share-expire-step
branch
from
d46058e to
43269fb
Compare
anon-pradip
force-pushed
the
test/test-for-flaky-share-expire-step
branch
13 times, most recently
from
5463f92 to
fd8d35d
Compare
anon-pradip
force-pushed
the
test/test-for-flaky-share-expire-step
branch
from
fd8d35d to
fb06f2c
Compare
|
amrita-shrestha
requested changes
Mar 18, 2025
| * @throws GuzzleException|JsonException | ||
| */ | ||
| public function expireResourceShare(string $user, string $resource, string $spaceName): ResponseInterface { | ||
| $rows['expireDate'] = $this->featureContext->formatExpiryDateTime('Y-m-d\\TH:i:sP'); |
There was a problem hiding this comment.
Suggested change
| $rows['expireDate'] = $this->featureContext->formatExpiryDateTime('Y-m-d\\TH:i:sP'); | |
| $rows['expireDate'] = $this->featureContext->formatExpiryDateTime('Y-m-d\\TH:i:sP'); |
Can we run tests locally with this format?
Do we even care about timezone P represents the timezone offset (e.g., +00:00, -05:00).
Could you try this format $date->format('Y-m-d H:i:s');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demonstration of test for #11001
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: