Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update importer #10880

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: update importer #10880

wants to merge 1 commit into from

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Jan 16, 2025

Description

Update the importer which is finally based on upstream Uppy/Companion.

Related Issue

Motivation and Context

Needs a 0.3.0 release of the importer and a new release of web.

Screenshots (if appropriate):

It looks slightly different than the old version:

host docker internal_9200_files_spaces_personal_admin_fileId=039d7651-b67a-40ae-ab6a-df0c39d1ce96%244eb2449f-5cb1-4875-a267-07f6f2a5ee2e%214eb2449f-5cb1-4875-a267-07f6f2a5ee2e items-per-page=100 files-spaces-generic-view-mode=resource-table

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@dschmidt dschmidt force-pushed the chore/update-importer branch from e3be0fb to 41a5390 Compare January 16, 2025 10:27
@mmattel
Copy link
Contributor

mmattel commented Jan 16, 2025

No port to 7.1, will be part of the next release - this gives room for final testing

Needs an entry in the upcoming ocis release notes (docs-main) and a note in the upgrade guide in the admin docs (docs-ocis).

@kobergj fyi

@wkloucek
Copy link
Contributor

wkloucek commented Feb 3, 2025

@dschmidt how do we continue with this PR?

@dschmidt
Copy link
Member Author

dschmidt commented Feb 3, 2025

The PR is ready to be tested once Web with my changes has been released and bumped in ocis.

@LukasHirt @kobergj

@wkloucek
Copy link
Contributor

wkloucek commented Feb 3, 2025

The PR is ready to be tested once Web with my changes has been released and bumped in ocis.

From a date perspective, this should be included in oC Web 11.1.0 and up.

This means it's gonna be included in oCIS 7.1.0 (currently available in RC state)

@LukasHirt
Copy link
Collaborator

This means it's gonna be included in oCIS 7.1.0 (currently available in RC state)

With @kobergj we discussed having this in the next release. Instead bringing the notifications settings in the 7.1.0. Or did this decision change @kobergj ?

@kobergj
Copy link
Collaborator

kobergj commented Feb 3, 2025

No. It's still the same. Will not be in 7.1 as it requires proper testing.

@wkloucek
Copy link
Contributor

wkloucek commented Feb 3, 2025

Will not be in 7.1 as it requires proper testing.

But the above PRs are already merged and available in oC Web!? From what I understand it's already part of 7.0.0-rc.4 ?

@kobergj
Copy link
Collaborator

kobergj commented Feb 3, 2025

No. Web is build from stable branch. Master is ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants