-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all paths configurable and default to a subdir of the /var/tmp/ocis #1080
Conversation
637f02a
to
ee59154
Compare
ee59154
to
97c6117
Compare
|
||
Aligned all services to use a subdir of `/var/tmp/ocis/` by default. Also made some missing temp paths configurable via env vars and config flags. | ||
|
||
https://github.com/owncloud/ocis/pulls/1080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is wrong with the change log? Does it really require an issue link?!?
file ../changelog/unreleased/make-all-paths-configurable.md: primary issue ID not found
exit status 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that using backticks might be problem, specially in line 1. That ends with a backtick, and maybe there is an edge-case problem with that sort of thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd guess the same. The structure of the changelog looks ok - a primary URL is required, but it can be any URL (issue, PR, third party resource, ...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had .../pulls/1080
instead of .../pull/1080
in it ... which really does not exist ... 😞
aaae344
to
bdef377
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
bdef377
to
901be34
Compare
wtf https://drone.owncloud.com/owncloud/ocis/2198/38/4 :
already in use ... hm phoenix -> web rename ? I restarted the build ... seems like a hiccup. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Aligned all services to use a subdir of
/var/tmp/ocis/
by default. Also made some missing temp paths configurable via env vars and config flags.This does change default paths and also two env vars which were missing the STORAGE_ prefix. Nothing critical.
related: #1048