fix impersonated request user mismatch #10550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
requested changes
Nov 12, 2024
changelog/unreleased/fix-auth-app.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| Bugfix: Fix impersonated request user mismatch | |||
|
|
|||
| We fixed a user id and mane mismatch in the impersonated auth-app API request | |||
There was a problem hiding this comment.
Suggested change
| We fixed a user id and mane mismatch in the impersonated auth-app API request | |
| We fixed a user id and name mismatch in the impersonated auth-app API request |
| if err != nil { | ||
| sublog.Error().Err(err).Msg("error authenticating user") | ||
| if strings.Contains(err.Error(), "requested user does not match") { |
There was a problem hiding this comment.
use a dedicated error type if you want to react on it. String matching will always end up in bugs :)
micbar
approved these changes
Nov 12, 2024
|
kobergj
approved these changes
Nov 13, 2024
ownclouders
pushed a commit
that referenced
this pull request
Nov 13, 2024
fix impersonated request user mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fixed a user id and name mismatch in the impersonated auth-app API request
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: