Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the memlimit default loglevel to error #10433

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Oct 28, 2024

Description

set the memlimit default loglevel to error.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 requested review from rhafer and kobergj October 29, 2024 09:45
@2403905
Copy link
Contributor Author

2403905 commented Oct 29, 2024

@kobergj @rhafer Can we just set an Error level for the memelimit?

@mmattel mmattel closed this Oct 29, 2024
@mmattel mmattel reopened this Oct 29, 2024
@mmattel
Copy link
Contributor

mmattel commented Oct 29, 2024

Sorry, pressed the wrong button 🤦‍♂️

@mmattel
Copy link
Contributor

mmattel commented Oct 29, 2024

@2403905 you are the expert 😄 but you could catch any error returned and log it. See the SetGoMemLimitWithOpts source. Then we see if something went wrong during initialisation 😃

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@2403905 2403905 merged commit f86b5e3 into owncloud:master Oct 29, 2024
2 of 3 checks passed
ownclouders pushed a commit that referenced this pull request Oct 29, 2024
set the memlimit default loglevel to error
This was referenced Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KimMachineGun/automemlimit is polluting log and cli output
3 participants