-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wopi host and sharing urls #10174
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@jvillafanez I see that our collabora fileinfo does not include these 3 Urls. Is that on purpose? |
I didn't see those properties documented in https://sdk.collaboraonline.com/docs/advanced_integration.html so I assumed they don't support them. |
c4a365b
to
0067ce2
Compare
@tbsbdr @kulmann @JammingBen
It would be great to inform the user, that the operation is not possible while the file is locked. @kulmann @AlexAndBear I created owncloud/web#11667 to track that. |
@ScharfViktor I adapted some API tests to cover the new properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from testing side
0067ce2
to
00c9302
Compare
|
feat: add wopi host and sharing urls
@NannaBarz @d7oc @dj4oC This could have an impact on the user guides. |
Description
This adds 4 important missing properties for OnlyOffice and Microsoft365.
Use Case
Screenshots
If you click these buttons, you get a new tab openend with the file list and the sidebar is opened in the desired mode.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: