Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wopi host and sharing urls #10174

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat: add wopi host and sharing urls #10174

merged 1 commit into from
Sep 30, 2024

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Sep 26, 2024

Description

This adds 4 important missing properties for OnlyOffice and Microsoft365.

Use Case

  • Switch the View modes (View / Edit) in Microsoft365 and Microsoft Office Online
  • Adds a "Share" button to open the share dialogue.
  • Adds a "Version History" link in the files menu

Screenshots

1727379362935
1727379332167

If you click these buttons, you get a new tab openend with the file list and the sidebar is opened in the desired mode.

1727379502161

1727379584594

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Sep 26, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar
Copy link
Contributor Author

micbar commented Sep 26, 2024

@jvillafanez I see that our collabora fileinfo does not include these 3 Urls. Is that on purpose?

@jvillafanez
Copy link
Member

I didn't see those properties documented in https://sdk.collaboraonline.com/docs/advanced_integration.html so I assumed they don't support them.

@micbar micbar force-pushed the wopi-host-urls branch 4 times, most recently from c4a365b to 0067ce2 Compare September 26, 2024 19:53
@micbar micbar marked this pull request as ready for review September 26, 2024 19:54
@micbar micbar mentioned this pull request Sep 26, 2024
14 tasks
@micbar
Copy link
Contributor Author

micbar commented Sep 26, 2024

@tbsbdr @kulmann @JammingBen
We have a small UI issue with ownCloud Web.

  1. Open File in WebOffice
  2. Go to the versions tab
  3. Click on "Restore" on a previous version
  4. Nothing happens - which is correct because the file is locked (the request in the network tab gets a 423 response)

It would be great to inform the user, that the operation is not possible while the file is locked.

@kulmann @AlexAndBear
There is a bigger issue on the app-external page. The param view_mode is not used by web, it only checks the permissions on the file. The use case here is, if we add view_mode=view on an editable file on the app-external page, it should be used in the app/open request to select the desired view mode.

I created owncloud/web#11667 to track that.

@micbar
Copy link
Contributor Author

micbar commented Sep 26, 2024

@ScharfViktor I adapted some API tests to cover the new properties.

@micbar micbar requested a review from ScharfViktor September 26, 2024 20:12
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from testing side

Copy link

@micbar micbar merged commit c384692 into master Sep 30, 2024
4 checks passed
@micbar micbar deleted the wopi-host-urls branch September 30, 2024 08:02
ownclouders pushed a commit that referenced this pull request Sep 30, 2024
feat: add wopi host and sharing urls
@micbar micbar mentioned this pull request Sep 30, 2024
9 tasks
@micbar
Copy link
Contributor Author

micbar commented Sep 30, 2024

@NannaBarz @d7oc @dj4oC This could have an impact on the user guides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants