Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCIS binary ignores PHOENIX_* env vars #454

Closed
PVince81 opened this issue Aug 13, 2020 · 2 comments
Closed

OCIS binary ignores PHOENIX_* env vars #454

PVince81 opened this issue Aug 13, 2020 · 2 comments

Comments

@PVince81
Copy link
Contributor

See #450 (comment)

It appears that despite using the PHOENIX_ env vars, the ocis-phoenix still has side effects.

to verify, I ran PHOENIX_ASSET_PATH=~/work/workspace/ PHOENIX_WEB_CONFIG=~/work/workspace/phoenix/config-ocis.json OCIS_LOG_LEVEL=debug bin/ocis-debug --log-level=debug server > /var/tmp/ocis/ocis.log 2>&1 where there's no Phoenix in the ASSET_PATH.

=> the UI still renders..

so this means those env variables are not used at all...

in the past I believe I've usually set those while running ocis-phoenix, not ocis...
we should fix this...

@PVince81 PVince81 added the bug label Aug 13, 2020
@kulmann
Copy link
Contributor

kulmann commented Aug 13, 2020

Addressed in owncloud/ocis-phoenix#76 and owncloud/ocis-phoenix#77.

@kulmann kulmann closed this as completed Aug 13, 2020
@kulmann
Copy link
Contributor

kulmann commented Aug 13, 2020

Already closing, since owncloud/ocis-phoenix#76 is merged and was the critical one. Missing config was already shown in the web ui. owncloud/ocis-phoenix#77 only aligns the service behaviour for an invalid config path with the one for an invalid asset path.

refs pushed a commit that referenced this issue Sep 18, 2020
Update reva to v1.2.1-0.20200826162318-c0f54e1f37ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants