Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

improve wopiserver #5

Merged
merged 13 commits into from
May 27, 2021
Merged

improve wopiserver #5

merged 13 commits into from
May 27, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 20, 2021 •
edited
Loading

DONE:

  • mint token and use/wopi/iop/open endpoint
  • dynamically determine open mode (read-write / read-only / file creation)
  • add more file extensions
  • fix collabora open arguments
  • refactor file open action

transfer to ticket

@wkloucek wkloucek requested a review from refs May 25, 2021 10:07
@wkloucek wkloucek marked this pull request as ready for review May 25, 2021 10:07
@wkloucek wkloucek requested review from C0rby and kulmann May 25, 2021 10:07
wkloucek added a commit to owncloud/ocis that referenced this pull request May 25, 2021
@wkloucek
fix deployment for owncloud/ocis-wopiserver#5
9b34a97
@wkloucek wkloucek mentioned this pull request May 25, 2021
Merged
C0rby
C0rby approved these changes May 27, 2021
View reviewed changes
Copy link

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

pkg/service/v0/service.go Outdated Show resolved Hide resolved
pkg/service/v0/service.go Outdated Show resolved Hide resolved
refs
refs approved these changes May 27, 2021
View reviewed changes
pkg/flagset/flagset.go Outdated Show resolved Hide resolved
pkg/service/v0/service.go Outdated
viewPerm := statResponse.Info.PermissionSet.InitiateFileDownload
emptyFile := statResponse.Info.Size == 0

if editPerm && viewPerm && emptyFile {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a case where a switch might improve readability.

pkg/service/v0/service.go Outdated Show resolved Hide resolved
pkg/service/v0/service.go Outdated Show resolved Hide resolved
pkg/service/v0/service.go Show resolved Hide resolved
pkg/service/v0/service.go Outdated Show resolved Hide resolved
@wkloucek wkloucek mentioned this pull request May 27, 2021
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@refs refs mentioned this pull request May 27, 2021
Closed
@wkloucek wkloucek merged commit b4935f5 into main May 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the improve_wopiserver branch May 27, 2021 10:21
ownclouders pushed a commit that referenced this pull request May 27, 2021
@wkloucek
commit b4935f5
a1c2dcd 
Merge: 57ecdaa abf275a
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu May 27 12:21:28 2021 +0200

    Merge pull request #5 from owncloud/improve_wopiserver

    improve wopiserver
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@refs refs refs approved these changes

@C0rby C0rby C0rby approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @C0rby @refs