This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
limit thumbnails a users can access to his own #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs
approved these changes
May 26, 2020
pkg/service/v0/service.go
Outdated
| tokenString := auth[len("Bearer "):] // strip the bearer prefix | ||
|
|
||
| var claims map[string]interface{} | ||
| token, _ := jwt.ParseSigned(tokenString) |
pkg/thumbnail/storage/filesystem.go
Outdated
| return p[0] | ||
| } | ||
|
|
||
| func (s FileSystem) storeImage(key string, img []byte) (string, error) { |
There was a problem hiding this comment.
How about making this method thread safe by adding a sync.Mutex and acquiring on every write? If this method runs on a goroutine, they should be thread safe
refs
changed the title
C0rby
force-pushed
the
feature/group-thumbnails-by-users
branch
3 times, most recently
from
0381ff6 to
80dbdd7
Compare
C0rby
force-pushed
the
feature/group-thumbnails-by-users
branch
from
80dbdd7 to
4ae1a64
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of the service can no longer request thumbnails of another users by guessing the etag.
The thumbnails are now only accessible by the users who created the thumbnail.
Closes #5.