-
Notifications
You must be signed in to change notification settings - Fork 5
Separate user and auth providers, add config for rest user #412
Conversation
@ishank011 What is the user story behind this change? |
@micbar at CERN we use OIDC for authentication, and then we have a REST API service which provides details about the other users and group resolution functionality. Previously, both the authprovider (basic auth) and userprovider services used the same driver, which didn't work for us because if we tried to set the value of this driver to rest, it would fail because there's no basic auth driver with that name. So the first two changes are about enabling that. Since the rest driver is CERN-specific, maybe we shouldn't add it here, but in a separate fork. This change adds the capability to eos fs to call the userprovider service to lookup UIDs for users and vice versa. So the third bullet adds the config for that that. The fourth change allows us to look up additional claims, namely uid and gid, from the OIDC tokens. |
@micbar this change is not only useful for us but to many deployments of current ownCloud. Let me explain that. |
1fe82a0
to
6f4debc
Compare
@butonic @ishank011 needs rebase. |
a5c71fc
to
0444190
Compare
@butonic can you restart the build? An unrelated test failed.
|
pkg/config/config.go
Outdated
RedisAddress string | ||
RedisUsername string | ||
RedisPassword string | ||
UserGroupsCacheExpiration int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to the bottom of the struct properties, so we have string first, then int ...
some checks down the line might be picky about this ... 🤷♂️
and do a quick rebase,pls. then I'll merge |
0444190
to
332a8e8
Compare
332a8e8
to
d4c6409
Compare
Here is an overview of what got changed by this pull request: Clones removed
==============
+ pkg/command/users.go -1
+ pkg/command/authbasic.go -1
See the complete overview on Codacy |
This PR