-
Notifications
You must be signed in to change notification settings - Fork 2
Use UUID for account lookup from presigned URLs #84
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Remove claims query preparation as we already have the information available.
I'm stuck now as I don't have enough understanding of the auth layers. Before this PR, the "presigned_url" middleware would prepare some claims query with the username that is then resolved by the next middleware "account_uuid". However I noticed in the logs that even if I don't pass in anything to the "account_uuid" through the context, it still manages to find the correct account and claims, and then mints the token. Still, despite "x-access-token" being set with the minted token, reva complains that there is no bearer header. Not sure how this could even work before my change since the Bearer header is never set, and the previous logic seemed to also rely on "x-access-token". This is the log output from the download request:
@butonic we'll need your help here |
also to note: the user's validity is already verified by |
obsoleted by #85 |
Other part of owncloud/ocis-ocs#32