This repository has been archived by the owner on Apr 19, 2022. It is now read-only.
DO NOT MERGE Add most recent compiled phoenix assets #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@kulmann please provide instructions about how you did this update. then redo the update to hopefully fix owncloud/ocis#450 |
|
instructions added in PR description @PVince81 |
kulmann
force-pushed
the
phoenix-assets-2020-07-27
branch
from
907ba1a to
0369dc8
Compare
kulmann
force-pushed
the
phoenix-assets-2020-07-27
branch
from
0369dc8 to
f66a643
Compare
|
Superseded by #78 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR is just a draft with most recent compiled phoenix assets, so that we can pin our ocis release branch to it. Delete this, as soon as we have an actual phoenix release and built assets from that.
Steps for achieving this:
1: make sure your local phoenix master is up to date
2:
yarn distfor phoenix. This will result in adistfolder3: copy the contents of
disttoocis-phoenix/assets/4: run
make generateinocis-phoenix. This will create an updatedembed.gofile.5: commit and push
You can use the version of ocis-phoenix in other go modules by pinning ocis-phoenix to your commit id:
go get github.com/owncloud/ocis-phoenix@<commit-id>