Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix upload issues by always providing OCIS_CORS_ALLOW_ORIGINS #744

Merged
merged 3 commits into from
Sep 12, 2024
Merged

fix upload issues by always providing OCIS_CORS_ALLOW_ORIGINS #744

merged 3 commits into from
Sep 12, 2024

Conversation

wkloucek
Copy link
Contributor

Description

fix uploads that are larger than 10MB

Related Issue

Motivation and Context

How Has This Been Tested?

  • development-install deployment example in minikube -> upload a file bigger than 10MB

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@wkloucek wkloucek requested review from case0sh and d7oc September 12, 2024 05:47
@wkloucek wkloucek marked this pull request as draft September 12, 2024 05:48
@wkloucek wkloucek changed the title fix upload issues by providing OCIS_URL that is used in fallback for OCIS_CORS_ALLOW_ORIGINS fix upload issues by always providing OCIS_CORS_ALLOW_ORIGINS Sep 12, 2024
@wkloucek wkloucek marked this pull request as ready for review September 12, 2024 05:50
@wkloucek wkloucek marked this pull request as draft September 12, 2024 06:02
@wkloucek wkloucek mentioned this pull request Sep 12, 2024
Open
@wkloucek wkloucek marked this pull request as ready for review September 12, 2024 07:47
@wkloucek wkloucek merged commit f6db171 into owncloud:main Sep 12, 2024
1 check passed
@wkloucek wkloucek deleted the fix-upload-issues branch September 12, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7oc d7oc d7oc approved these changes

@case0sh case0sh Awaiting requested review from case0sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chunked upload fails on with oCIS 6
2 participants
@wkloucek @d7oc