Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Atomic requests to the accounts service #82

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Atomic requests to the accounts service #82

merged 5 commits into from
Aug 11, 2020

Conversation

refs
Copy link
Member

@refs refs commented Aug 7, 2020

This PR is probably the equivalent of using a cannon to exterminate a fly. It makes every request to the provisioning API atomic, this way operations on the file system level are ensured to be atomic, and not bothered by any other request.

  • update groups

api tests

dependencies

methodology

make test-acceptance-api TEST_SERVER_URL=https://localhost:9200 TEST_OCIS=true OCIS_REVA_DATA_ROOT=/var/tmp/reva/ SKELETON_DIR=apps/testing/data/apiSkeleton BEHAT_FILTER_TAGS='~@skipOnOcis&&~@skipOnOcis-OC-Storage' TESTING_REMOTE_SYSTEM=true BEHAT_FEATURE=tests/acceptance/features/apiShareManagementBasic/createShare.feature

@update-docs
Copy link

update-docs bot commented Aug 7, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann mentioned this pull request Aug 10, 2020
63 tasks
@PVince81 PVince81 requested a review from butonic August 10, 2020 15:00
@PVince81
Copy link
Contributor

changelog please.

@butonic can you review ?

Signed-off-by: A.Unger <zyxancf@gmail.com>
@refs refs self-assigned this Aug 11, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Coverage increased per file
===========================
+ pkg/service/v0/accounts.go  1
         

Clones removed
==============
+ pkg/service/v0/accounts.go  -2
         

See the complete overview on Codacy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants