Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop-tus] TUS support w/o message-queue dependency #67

Merged
merged 4 commits into from
May 27, 2020

Conversation

felix-schwarz
Copy link
Collaborator

@felix-schwarz felix-schwarz commented May 27, 2020

Description

Development of TUS support originally started based on the feature/message-queue branch.

To allow testing of TUS support without also merging feature/message-queue, this branch provides a version of the develop branch with just the TUS-related changes added.

Related issue

#65

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

	- NSString+TUSMetadata: conversion from dictionary to Upload-Metadata - and back
	- OCTUSHeader: new class to simplify parsing, building and conversion of TUS-related headers
	- OCTUSJob: new class to manage the current status of a TUS upload
	- OCTUSJobSegment: new class to abstract away file segmentation details for TUS uploads
- OCConnection:
	- add new OCConnectionDelegate method to inject/modify TUS capabilities / settings
	- add new OCConnectionOptionTemporarySegmentFolderURLKey option key to provide a temporary folder to store file segments in when performing uploads via TUS
	- add code to upload files via TUS where available
- OCSyncActionUpload: add OCConnectionOptionTemporarySegmentFolderURLKey option to ensure persistence of temporary segment files
- OCEvent:
	- add OCTUSHeader, OCTUSJob and OCTUSJobSegment to .safeClasses
	- modernize initWithCoder
- OCHTTP:
	- add OCHTTPStaticHeaderFields type and switch OCHTTPResponse over
	- add OCHTTPMethodPATCH method
	- add support for TUS capabilities information provided via the capabilities endpoint
- OCConnection
	- apply OCCapabilities.tusMaxChunkSize to TUS uploads if available
- OCTUSHeader
	- clarify .maximumSize is the maximum file size and add new .maximumChunkSize to supply a maximum chunk size
	- add new OCTUSCapabilityKey and OCTUSCapability types as needed by OCCapabilities
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@felix-schwarz felix-schwarz merged commit 7f7fb1b into develop May 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-tus branch May 27, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants