Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated LDAP screenshots #1092

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Updated LDAP screenshots #1092

merged 3 commits into from
Aug 28, 2023

Conversation

d7oc
Copy link
Contributor

@d7oc d7oc commented Aug 25, 2023

This PR addresses #738 and updates the LDAP screenshots.

@d7oc d7oc requested a review from mmattel August 25, 2023 14:09
@mmattel
Copy link
Contributor

mmattel commented Aug 28, 2023

Many thanks for the effort 😄

Can you do me a favour. It is about the frame size of the screenshots taken.

I would help readbility a lot if you coud redo the screenshots but make the browser window smaller. In particular to a size where the latest tab is the width limit, respectivele if there are no tabs to a renderable friendly size but not full width. Any text rendered will anyway break to multilines correctly. Else the image is so big that any content shown gets unidentifyable (too small).

@d7oc
Copy link
Contributor Author

d7oc commented Aug 28, 2023

Updated screenshots according remarks in 2f99b9b.

@mmattel
Copy link
Contributor

mmattel commented Aug 28, 2023

More updates:

  • image --> center
  • image --> default width
  • remove not necessary linebreaks
  • comment out an image that was referenced bot nowhere existing

Backport to 10.13 and 10.12

@mmattel mmattel merged commit fa04515 into master Aug 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the d7oc/ldap_screenshot_updates branch August 28, 2023 13:01
mmattel added a commit that referenced this pull request Aug 28, 2023
mmattel added a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants