Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Refactored inter scenarios space #40463

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[full-ci] [tests-only] Refactored inter scenarios space #40463

merged 1 commit into from
Oct 31, 2022

Conversation

grgprarup
Copy link
Contributor

Description

Interspacing between two scenarios is made consistent as documented https://github.com/owncloud/docs-server/pull/697/files#diff-12a0f404a5bbbda65e50018a487cd725797106d670f4308b921d2081dc4b3516R1129-R1154:~:text=more%20relevant%20discussion.-,%3D%3D%3D%3D%20Inter%2Dscenario%20spacings,%2D%2D%2D%2D,-Commenting%20on%20lines

Suites covered:

  • apiShareCreateSpecialToShares2
  • apiSharees
  • apiShareManagementBasicToRoot
  • apiShareManagementBasicToShares
  • apiShareManagementToRoot
  • apiShareManagementToShares
  • apiShareOperationsToRoot1
  • apiShareOperationsToRoot2
  • apiShareOperationsToShares1
  • apiShareOperationsToShares2

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup mentioned this pull request Oct 31, 2022
Closed
@grgprarup grgprarup marked this pull request as ready for review October 31, 2022 09:53
@grgprarup grgprarup requested review from SagarGi, kiranparajuli589, saw-jan, SwikritiT and amrita-shrestha and removed request for SagarGi October 31, 2022 09:53
@grgprarup grgprarup force-pushed the refactor-feature-files-3 branch from 0e4c616 to e1da24c Compare October 31, 2022 10:04
@phil-davis
Copy link
Contributor

CI only fails because of known issue #40457
I will merge this.

@phil-davis phil-davis merged commit 6fd0df3 into master Oct 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-feature-files-3 branch October 31, 2022 10:16
This was referenced Oct 31, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grgprarup @phil-davis