Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] allow underscore in expected-failures links #39804

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 17, 2022

Description

A lint checker for expected-failures files was added to CI in PR #39782
One of the checks is to find and validate the link that should be in () after an expected-failures feature file mention.
Links can contain an underscore character, e.g.:

-   [apiFilesSpaces/filesSpaces.feature:114](https://github.com/owncloud/files_spaces/blob/master/tests/acceptance/features/apiFilesSpaces/filesSpaces.feature#L114)

The repo is files_spaces.

This PR adds the _ to the allowed characters used to find matches of links.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit a6f745f into master Feb 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the underscore-in-expected-failures branch February 17, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants