Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] added last_login to getUser() #39351

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 13, 2021

Description

This is the code from https://github.com/ctcq/core/tree/provisioning-api-last-login - I have rebased it and adjusted the acceptance tests.

Related Issue

#38624

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@phil-davis phil-davis force-pushed the provisioning-api-last-login-20211013 branch from e7af219 to 0c18319 Compare November 2, 2021 09:41
@phil-davis phil-davis changed the title added last_login to getUser() [full-ci] added last_login to getUser() Nov 2, 2021
@phil-davis phil-davis self-assigned this Nov 2, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 2, 2021
@owncloud owncloud deleted a comment from ownclouders Nov 2, 2021
@phil-davis phil-davis marked this pull request as ready for review November 2, 2021 11:22
@phil-davis
Copy link
Contributor Author

@pmaier1 this should pass CI, and should be happily backward-compatible with existing consumers of the Provisioning API. It just adds a last_login data item to the data returned about a user.

See issue #38624 for the feature request.

Is it OK to proceed?

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. We should include a changelog item if we decide to add this.

@pmaier1
Copy link
Contributor

pmaier1 commented Nov 3, 2021

Is it OK to proceed?

Sure, thanks. Please consider dev docs and changelog. cc @mmattel

@phil-davis
Copy link
Contributor Author

Changelog added and docs issue owncloud/docs#4201 raised.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants