Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] some issue tag added #39316

Merged
merged 1 commit into from
Oct 3, 2021
Merged

[tests-only] [full-ci] some issue tag added #39316

merged 1 commit into from
Oct 3, 2021

Conversation

sakshamgurung
Copy link
Contributor

Description

Some missing issue tags added

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sakshamgurung sakshamgurung requested review from SwikritiT, swoichha, Talank and phil-davis and removed request for swoichha October 2, 2021 12:32
phil-davis
phil-davis approved these changes Oct 3, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this. But we need to discuss what to do about all the issue-ocis tags that are embedded in he core tests. The details can be found in the expected-failures files, so these tags are duplication and a nuisance to maintain.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 082c13c into master Oct 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the tags-added branch October 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@Talank Talank Awaiting requested review from Talank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakshamgurung @phil-davis