Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Match getcontenttype starting with text/plain in test #39045

Merged
merged 1 commit into from
Jul 22, 2021
Merged

[tests-only] Match getcontenttype starting with text/plain in test #39045

merged 1 commit into from
Jul 22, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 21, 2021 •
edited
Loading

Description

See owncloud/ocis#1302 (comment)

The getcontenttype attribute can be just text/plain or can have other parameters, for example text/plain; charset=utf-8. The test has been adjusted to allow any string starting with text/plain.

I also removed all the issue-ocis-reva-57 tags. They are very outdated, and we have expected-failures files nowadays that look after recording which test failures are related to which issues.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis requested a review from C0rby July 21, 2021 16:14
@phil-davis phil-davis self-assigned this Jul 21, 2021
@phil-davis phil-davis mentioned this pull request Jul 21, 2021
Closed
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiSharePublicLink2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31449/77/1

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 606ecd3 into master Jul 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the ocis-issue-1302 branch July 22, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different propfind response compared with core
3 participants
@phil-davis @ownclouders @kiranparajuli589