Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Update issue tag and expected failures following product#207 #38876

Merged
merged 6 commits into from
Jun 24, 2021
Merged

[tests-only] Update issue tag and expected failures following product#207 #38876

merged 6 commits into from
Jun 24, 2021

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jun 22, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Jun 22, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kiranparajuli589 kiranparajuli589 changed the title Share update expected failures [tests-only] Update issue tag and expected failures following product#207 Jun 22, 2021
@kiranparajuli589 kiranparajuli589 self-assigned this Jun 24, 2021
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review June 24, 2021 03:19
saw-jan
saw-jan reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranparajuli589 kiranparajuli589 force-pushed the share-update-expected-failures branch from 910194d to e4ecd3a Compare June 24, 2021 04:42
Talank
Talank reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit e5ca366 into master Jun 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the share-update-expected-failures branch June 24, 2021 07:22
@phil-davis phil-davis mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@dpakach dpakach Awaiting requested review from dpakach

@swoichha swoichha Awaiting requested review from swoichha

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCIS Response is empty when accepting a share
4 participants
@kiranparajuli589 @phil-davis @Talank @saw-jan