Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only]Cleans up shares after the deletion of the user #38678

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[Tests-Only]Cleans up shares after the deletion of the user #38678

merged 1 commit into from
Apr 30, 2021

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Apr 30, 2021 •
edited by phil-davis
Loading

Description

This PR minimizes the cleanup of user shares after the deletion of user

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 mentioned this pull request Apr 30, 2021
Closed
9 tasks
@jasson99 jasson99 force-pushed the adjustUserDataCleanup branch from 06d3691 to bd5a024 Compare April 30, 2021 12:41
@phil-davis phil-davis self-requested a review April 30, 2021 13:30
phil-davis
phil-davis approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we do not need this cleanup code any more.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit e8d1281 into master Apr 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjustUserDataCleanup branch April 30, 2021 13:47
This was referenced Apr 30, 2021
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasson99 @phil-davis