Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] enable group tests on ocis #38110

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 13, 2020

Description

Enable group tests in ocis

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@dpakach dpakach changed the title enable group tests on ocis [Tests-Only] enable group tests on ocis Nov 13, 2020
@owncloud owncloud deleted a comment from update-docs bot Nov 13, 2020
@dpakach dpakach force-pushed the enable-more-ocis-tests branch 3 times, most recently from 6d290e4 to 3be9a87 Compare November 13, 2020 10:40
@dpakach dpakach requested a review from phil-davis November 13, 2020 13:30
@dpakach dpakach self-assigned this Nov 13, 2020
@dpakach dpakach marked this pull request as ready for review November 13, 2020 13:33
And group "brand-new-group" has been created
And group "España" has been created
When the administrator gets all the groups using the provisioning API
Then the groups returned by the API should be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have the problem that the test scenario in core will need to be adjusted when the "default" groups in OCIS are changed. But we can think about that in a later PR - maybe this scenario could be moved into the local OCIS API tests, rather than being in core.

tests/acceptance/features/bootstrap/Provisioning.php Outdated Show resolved Hide resolved
@phil-davis phil-davis self-requested a review November 13, 2020 15:37
@dpakach dpakach force-pushed the enable-more-ocis-tests branch from 09f07a4 to 3b17d07 Compare November 18, 2020 04:02
@dpakach dpakach force-pushed the enable-more-ocis-tests branch from 3b17d07 to b5b29f3 Compare November 18, 2020 08:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants