[tests-only] Adjust logic for testing on OCIS or REVA #38077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, when testing on REVA you have to define bothe environment variables
TEST_OCIS
andTEST_REVA
- that is not such an obvious thing.adjust the test logic so that if just
TEST_REVA
is defined, then all the appropriate test setup and teardown happens.change the environment variable
TEST_EXTERNAL_USER_BACKENDS
toTEST_WITH_LDAP
to better reflect what it does. The test suite uses this environment variable to know to create/delete users and groups on LDAP... (rather than with the provisioning API)Note:
TEST_OCIS
is only documented inowncloud/ocis
repo. And the use of that does not change.TEST_REVA
andTEST_EXTERNAL_USER_BACKENDS
are only documented incs3org/reva
repo. That will be changed in the PR that bumps the core commit.None of these are mentioned in
owncloud/docs
so there is nothing to change there!I will make a PR in
user_ldap
repo to changeTEST_EXTERNAL_USER_BACKENDS
after this PR is merged.After this PR, we want to adjust the logic in a separate PR so that user data and shares are not cleaned up "under-the-hood" when running on OCIS. There is an OCIS PR in development that will cleanup user files, shares and other metadata correctly when the user is deleted using the provisioning API.
How Has This Been Tested?
CI
PR cs3org/reva#1295 demonstrates that this works.
Types of changes
Checklist: