-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] Make API tests pass on EOS #37575
Conversation
b625c9a
to
e29cd0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #37575 +/- ##
=========================================
Coverage 64.70% 64.70%
Complexity 19350 19350
=========================================
Files 1281 1281
Lines 75607 75607
Branches 1333 1333
=========================================
Hits 48920 48920
Misses 26295 26295
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #37575 +/- ##
=========================================
Coverage 64.74% 64.74%
Complexity 19360 19360
=========================================
Files 1281 1281
Lines 75622 75622
Branches 1333 1333
=========================================
Hits 48959 48959
Misses 26271 26271
Partials 392 392
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm taking over this PR |
e29cd0a
to
d8002dd
Compare
960d19f
to
a0c654e
Compare
7a531aa
to
0d7dd84
Compare
rebased and fixed conflicts |
fef0b46
to
50b3dba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also 2 occurrences of [a-f0-9:]{1,32}
in apiWebdavOperations/search.feature
- probably those should also be made more flexible.
Maybe we should have a substituteInLineCodes
item for this string. We keep changing it a bit and have to search-replace throughout the feature files. Maybe %etag_regex%
could expand to the regex?
tests/acceptance/features/apiWebdavUpload2/uploadFileUsingOldChunking.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiSharePublicLink1/deletePublicLinkShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature
Outdated
Show resolved
Hide resolved
50b3dba
to
3e0f7ed
Compare
making it more flexible is currently an issue because when checking the substitution in the headers we also run |
some tests fail in the ocis repo because of new enabled tests in 21803fd |
Description
Right now ocis behaves differently (partly) with EOS storage. This PR makes files permissions tests to pass on EOS
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: