-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make checksum propfind future proof #22199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning <oc:checksum>TYPE:CHECKSUM</oc:checksum> Return <oc:checksums> <oc:checksum>TYPE:CHECKSUM</oc:checksum> </oc:checksums> This will allow us to expand in the future to multiple checksums. Without doing just string concatenation. And even for a single checksum it is now correct.
By analyzing the blame information on this pull request, we identified @PVince81, @DeepDiver1975 and @LukasReschke to be potential reviewers |
|
@rullzer Seem to be broken. :( |
Tested with the updated file |
I'm O.K.with that. But please discuss architecture question like that with @DeepDiver1975 and me in the future. |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 9, 2016
Make checksum propfind future proof
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checksum PR from #21997 returns a propfind like:
Which if we will ever support multiple cheksums results in:
Which is not very webdavvy.
This PR moves that to:
Which is a bit more future proof.
Testing is basically the same as: #21997 (comment) with the exception that your propfind file should contain:
CC: @PVince81 @dragotin @MorrisJobke @nickvergessen