Stream zip or tar #19318

VicDeo · 2015-09-23T16:03:30Z

download directory content as tar for macs.
~~Depends on owncloud-archive/3rdparty#197~~
owncloud-archive/3rdparty#198
Ref #17930

P.S. Elementary tar structures spec for okteta hex editor

DeepDiver1975 · 2015-09-23T21:49:54Z

lib/private/streamer.php

+use \ZipStreamer\ZipStreamer;
+use DeepDiver1975\TarStreamer\TarStreamer;
+
+class OC_Streamer {


\OC\Streamer

DeepDiver1975 · 2015-09-24T15:09:17Z

zips and tars are generated and the tar can be opened on my linux machine.

Test on Mac os is still pending @LukasReschke

DeepDiver1975 · 2015-09-24T15:10:26Z

lib/private/streamer.php

+	private $streamerInstance;
+
+	/** @var string*/
+	private $extension;


DeepDiver1975 · 2015-09-24T15:45:04Z

THX @VicDeo

LukasReschke · 2015-09-24T15:49:48Z

Bugs:

Create a folder named test">, download it. Will be named test--.tar-;

Functionality:

Downloading an empty folder and extracting work on OS X
Downloading an folder with some files in it and extracting work on OS X
Downloading an folder with some files and subfolders in it and extracting work on OS X
Downloading an folder with only subfolders in it and extracting work on OS X
Downloading multiple folders works on OS X

DeepDiver1975 · 2015-09-24T15:56:42Z

tar file with a size of 4gb+

DeepDiver1975 · 2015-09-24T15:57:01Z

Create a folder named test">, download it. Will be named test--.tar-;

same for zip?

LukasReschke · 2015-09-24T15:57:37Z

same for zip?

Nope. ZIP on master produces test2--.zip

LukasReschke · 2015-09-24T16:06:40Z

tar file with a size of 4gb+

TAR files totalling more than 5GB seem to work fine here on OS X.

LukasReschke · 2015-09-24T16:08:22Z

same for zip?

Bug in the library 🙊 https://github.com/owncloud/3rdparty/pull/197/files#r40337737

VicDeo · 2015-09-24T18:38:49Z

Create a folder named test">, download it. Will be named test--.tar-;

@LukasReschke
now it is test--.tar. Is it ok? :)

DeepDiver1975 · 2015-09-24T19:11:05Z

TAR files totalling more than 5GB seem to work fine here on OS X.

nice 🚀

ghost · 2015-09-30T18:30:32Z

@DeepDiver1975 thanks!

rperezb · 2015-10-08T08:36:20Z

@SergioBertolinSG please

rperezb · 2015-10-08T08:42:08Z

Suggested test plan:

8.2

Expected result in every case: archives can be opened without error using the os archive tools

@SergioBertolinSG Editing:

Test 1: on the public share page	Result: MAC	Result: Windows	Result: Linux	Result: Mobile
File is downloaded	✅	✅	✅	✅
Folder is downloaded	✅	✅	✅	✅
Select some files within a folder and download them	✅	✅	✅	✅

Test 2: being logged in	Result: MAC	Result: Windows	Result: Linux	Result: Mobile
File is downloaded	✅	✅	✅	✅
Folder is downloaded	✅	✅	✅	✅
Select some files within a folder and download them	✅	✅	✅	✅

DeepDiver1975 · 2015-10-08T09:01:00Z

And also add test cases with files and folder with a name longer then 100 chars - see owncloud/TarStreamer#4 (comment)

SergioBertolinSG · 2015-10-08T09:02:27Z

One file downloaded in a public share in OS X downloads a tar file instead of the file directly. Is this a problem? I find it annoying because it is just one file and you have to open it twice (open .tar + real open).

DeepDiver1975 · 2015-10-08T09:03:25Z

One file downloaded in a public share in OS X downloads a tar file instead of the file directly. Is this a problem? I find it annoying because it is just one file and you have to open it twice (open .tar + real open).

This was fixed yesterday - please use current master for testing

SergioBertolinSG · 2015-10-08T09:04:15Z

Ok, I was using 8.2RC1.

SergioBertolinSG · 2015-10-08T09:28:15Z

When downloading a public shared folder the name of the file is always download.tar, instead of the folder name, inside the folder has the proper name.
When selecting several files of this shared folder, the downloaded file is called like the shared folder.
It should be the opposite isn't? the selected files downloaded in download.tar and the whole folder with {folder_shared_name}.tar

PVince81 · 2015-10-08T09:31:04Z

@SergioBertolinSG maybe, can you raise a ticket for that ?

DeepDiver1975 · 2015-10-08T09:32:45Z

@nickvergessen another testcase for smashbox?

nickvergessen · 2015-10-08T09:47:11Z

@nickvergessen another testcase for smashbox?

Once the issue is fixed I can try to get ti working. Currently I specify the full-path in the curl request that grabs the zip. So that would need a check for the proposed file name instead.

SergioBertolinSG · 2015-10-08T10:36:56Z

@PVince81 raised #19646

DeepDiver1975 · 2015-10-08T10:51:40Z

I missinterpreted the original report - the behavior is like that since forever.
@SergioBertolinSG I'm sorry

DeepDiver1975 · 2015-10-08T15:37:55Z

And also add test cases with files and folder with a name longer then 100 chars - see owncloud/TarStreamer#4 (comment)

@SergioBertolinSG can you test this on macos please? THX

SergioBertolinSG · 2015-10-09T06:58:49Z

@DeepDiver1975 Yes I did, works fine. Same in windows and linux.

VicDeo force-pushed the tarstreamer branch 2 times, most recently from c4f75ec to 5edd872 Compare September 23, 2015 21:06

VicDeo added the 2 - Developing label Sep 23, 2015

DeepDiver1975 added this to the 8.2-current milestone Sep 23, 2015

DeepDiver1975 reviewed Sep 23, 2015
View reviewed changes

This was referenced Sep 24, 2015

Download directory as zip while an inner file is being overwritten causes the download to be corrupted #16960

Closed

Problems with Zip Files after upgrade to 7.0.0 #10001

Closed

DeepDiver1975 force-pushed the tarstreamer branch from b9fb750 to c91f12c Compare September 24, 2015 12:52

DeepDiver1975 reviewed Sep 24, 2015
View reviewed changes

lib/private/streamer.php

private $streamerInstance;

/** @var string*/

private $extension;

Copy link

Member

DeepDiver1975 Sep 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

VicDeo force-pushed the tarstreamer branch from f27c6cb to ce8dba6 Compare September 24, 2015 15:25

LukasReschke self-assigned this Sep 24, 2015

VicDeo force-pushed the tarstreamer branch 2 times, most recently from d3de42c to 7e56f60 Compare September 24, 2015 18:35

LukasReschke removed their assignment Sep 25, 2015

DeepDiver1975 force-pushed the tarstreamer branch from 177315e to d5fa03d Compare September 25, 2015 21:34

DeepDiver1975 changed the title ~~[WIP] Stream zip or tar~~ Stream zip or tar Sep 25, 2015

DeepDiver1975 self-assigned this Sep 29, 2015

DeepDiver1975 restored the tarstreamer branch September 30, 2015 08:15

DeepDiver1975 deleted the tarstreamer branch September 30, 2015 08:20

DeepDiver1975 mentioned this pull request Sep 30, 2015

[stable8.1] backport Tarstreamer #19466

Merged

MorrisJobke removed the backport-request label Oct 1, 2015

DeepDiver1975 mentioned this pull request Oct 8, 2015

Filenames longer then 99 chars seem not to be implemented properly ... owncloud/TarStreamer#4

Closed

MorrisJobke added the approved by qa label Oct 9, 2015

taligentx mentioned this pull request Oct 19, 2015

8.2RC1 Files - Downloading entire subdirectories produces 0-byte .tar and .zip files #19854

Closed

MorrisJobke added 8.2.1-current and removed 8.2.1-current labels Nov 11, 2015

MorrisJobke added blue-ticket and removed resolves-blue-ticket labels Jan 7, 2016

ghost mentioned this pull request Jul 11, 2016

[Mac OS] Download of a folder results in a corrupt zip file. #13669

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stream zip or tar #19318

Stream zip or tar #19318

VicDeo commented Sep 23, 2015

DeepDiver1975 Sep 23, 2015

DeepDiver1975 commented Sep 24, 2015

DeepDiver1975 Sep 24, 2015

DeepDiver1975 commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

DeepDiver1975 commented Sep 24, 2015

DeepDiver1975 commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

VicDeo commented Sep 24, 2015

DeepDiver1975 commented Sep 24, 2015

ghost commented Sep 30, 2015

rperezb commented Oct 8, 2015

rperezb commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

PVince81 commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

nickvergessen commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

SergioBertolinSG commented Oct 9, 2015

Stream zip or tar #19318

Stream zip or tar #19318

Conversation

VicDeo commented Sep 23, 2015

DeepDiver1975 Sep 23, 2015

Choose a reason for hiding this comment

DeepDiver1975 commented Sep 24, 2015

DeepDiver1975 Sep 24, 2015

Choose a reason for hiding this comment

DeepDiver1975 commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

DeepDiver1975 commented Sep 24, 2015

DeepDiver1975 commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

LukasReschke commented Sep 24, 2015

VicDeo commented Sep 24, 2015

DeepDiver1975 commented Sep 24, 2015

ghost commented Sep 30, 2015

rperezb commented Oct 8, 2015

rperezb commented Oct 8, 2015

8.2

DeepDiver1975 commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

PVince81 commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

nickvergessen commented Oct 8, 2015

SergioBertolinSG commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

DeepDiver1975 commented Oct 8, 2015

SergioBertolinSG commented Oct 9, 2015